Fix feature check in apps (missing parenthesis), allow multiple requires (comma separated)

This commit is contained in:
Stefan Parviainen 2014-12-22 17:45:43 +01:00
parent d3830aea96
commit bd2be2b10c

View File

@ -83,35 +83,37 @@ function parse_app_description($f) {
$ret['target'] = str_replace(array('\'','"'),array(''','&dquot;'),$ret['target']);
if(array_key_exists('requires',$ret)) {
$require = trim(strtolower($ret['requires']));
switch($require) {
case 'nologin':
if(local_user())
unset($ret);
break;
case 'admin':
if(! is_site_admin())
unset($ret);
break;
case 'local_user':
if(! local_user())
unset($ret);
break;
case 'public_profile':
if(! is_public_profile())
unset($ret);
break;
case 'observer':
if(! $observer)
unset($ret);
break;
default:
if(! local_user() && feature_enabled(local_user(),$require))
unset($ret);
break;
$requires = explode(',',$ret['requires']);
foreach($requires as $require) {
$require = trim(strtolower($require));
switch($require) {
case 'nologin':
if(local_user())
unset($ret);
break;
case 'admin':
if(! is_site_admin())
unset($ret);
break;
case 'local_user':
if(! local_user())
unset($ret);
break;
case 'public_profile':
if(! is_public_profile())
unset($ret);
break;
case 'observer':
if(! $observer)
unset($ret);
break;
default:
if(! (local_user() && feature_enabled(local_user(),$require)))
unset($ret);
break;
}
}
// logger('require: ' . print_r($ret,true));
}
if($ret) {
translate_system_apps($ret);
@ -189,34 +191,37 @@ function app_render($papp,$mode = 'view') {
$papp['desc'] = str_replace(array('\'','"'),array(''','&dquot;'),$papp['desc']);
if($k === 'requires') {
$require = trim(strtolower($v));
switch($require) {
case 'nologin':
if(local_user())
return '';
break;
case 'admin':
if(! is_site_admin())
return '';
break;
case 'local_user':
if(! local_user())
return '';
break;
case 'public_profile':
if(! is_public_profile())
return '';
break;
case 'observer':
$observer = get_app()->get_observer();
if(! $observer)
return '';
break;
default:
if(! local_user() && feature_enabled(local_user(),$require))
return '';
break;
$requires = explode(',',$v);
foreach($requires as $require) {
$require = trim(strtolower($require));
switch($require) {
case 'nologin':
if(local_user())
return '';
break;
case 'admin':
if(! is_site_admin())
return '';
break;
case 'local_user':
if(! local_user())
return '';
break;
case 'public_profile':
if(! is_public_profile())
return '';
break;
case 'observer':
$observer = get_app()->get_observer();
if(! $observer)
return '';
break;
default:
if(! (local_user() && feature_enabled(local_user(),$require)))
return '';
break;
}
}
}