fix bitrot in util/zotsh

Zotlabs/Module/Admin/Addons.php

@@ -2,6 +2,7 @@
 
 namespace Zotlabs\Module\Admin;
 
+use App;
 use \Zotlabs\Storage\GitRepo;
 use \Michelf\MarkdownExtra;
 
@@ -253,14 +254,14 @@ class Addons {
 		 * Single plugin
 		 */
 
-		if (\App::$argc == 3){
+		if (App::$argc == 3){
-			$plugin = \App::$argv[2];
+			$plugin = App::$argv[2];
 			if (!is_file("addon/$plugin/$plugin.php")){
 				notice( t("Item not found.") );
 				return '';
 			}
 
-			$enabled = in_array($plugin,\App::$plugins);
+			$enabled = in_array($plugin,App::$plugins);
 			$info = get_plugin_info($plugin);
 			$x = check_plugin_versions($info);
 
@@ -268,11 +269,11 @@ class Addons {
 
 			if($enabled && ! $x) {
 				$enabled = false;
-				$idz = array_search($plugin, \App::$plugins);
+				$idz = array_search($plugin, App::$plugins);
 				if ($idz !== false) {
-					unset(\App::$plugins[$idz]);
+					unset(App::$plugins[$idz]);
 					uninstall_plugin($plugin);
-					set_config("system","addon", implode(", ",\App::$plugins));
+					set_config("system","addon", implode(", ",App::$plugins));
 				}
 			}
 			$info['disabled'] = 1-intval($x);
@@ -281,19 +282,19 @@ class Addons {
 				check_form_security_token_redirectOnErr('/admin/addons', 'admin_addons', 't');
 				$pinstalled = false;
 				// Toggle plugin status
-				$idx = array_search($plugin, \App::$plugins);
+				$idx = array_search($plugin, App::$plugins);
 				if ($idx !== false){
-					unset(\App::$plugins[$idx]);
+					unset(App::$plugins[$idx]);
 					uninstall_plugin($plugin);
 					$pinstalled = false;
 					info( sprintf( t("Plugin %s disabled."), $plugin ) );
 				} else {
-					\App::$plugins[] = $plugin;
+					App::$plugins[] = $plugin;
 					install_plugin($plugin);
 					$pinstalled = true;
 					info( sprintf( t("Plugin %s enabled."), $plugin ) );
 				}
-				set_config("system","addon", implode(", ",\App::$plugins));
+				set_config("system","addon", implode(", ",App::$plugins));
 
 				if($pinstalled) {
 					@require_once("addon/$plugin/$plugin.php");
@@ -305,7 +306,7 @@ class Addons {
 
 			// display plugin details
 
-			if (in_array($plugin, \App::$plugins)){
+			if (in_array($plugin, App::$plugins)){
 				$status = 'on';
 				$action = t('Disable');
 			} else {
@@ -380,18 +381,18 @@ class Addons {
 
 					list($tmp, $id) = array_map('trim', explode('/', $file));
 					$info = get_plugin_info($id);
-					$enabled = in_array($id,\App::$plugins);
+					$enabled = in_array($id,App::$plugins);
 					$x = check_plugin_versions($info);
 
 					// disable plugins which are installed but incompatible versions
 
 					if($enabled && ! $x) {
 						$enabled = false;
-						$idz = array_search($id, \App::$plugins);
+						$idz = array_search($id, App::$plugins);
 						if ($idz !== false) {
-							unset(\App::$plugins[$idz]);
+							unset(App::$plugins[$idz]);
 							uninstall_plugin($id);
-							set_config("system","addon", implode(", ",\App::$plugins));
+							set_config("system","addon", implode(", ",App::$plugins));
 						}
 					}
 					$info['disabled'] = 1-intval($x);

Zotlabs/Module/Cloud.php

@@ -35,13 +35,6 @@ class Cloud extends \Zotlabs\Web\Controller {
 		if (argc() > 1)
 			$which = argv(1);
 
-
-		if (argc() < 2 && intval(get_config('system','cloud_disable_siteroot'))) {
-			notice( t('Permission denied.') . EOL);
-			construct_page();
-			killme();
-		}
-
 		$profile = 0;
 
 		if ($which)

Zotlabs/Module/Dav.php

@@ -95,6 +95,8 @@ class Dav extends \Zotlabs\Web\Controller {
 
 
 		$auth = new \Zotlabs\Storage\BasicAuth();
+		$auth->observer = get_observer_hash();
+
 		$auth->setRealm(ucfirst(\Zotlabs\Lib\System::get_platform_name()) . ' ' . 'WebDAV');
 
 		$rootDirectory = new \Zotlabs\Storage\Directory('/', $auth);

Zotlabs/Storage/Directory.php

@@ -720,7 +720,11 @@ class Directory extends DAV\Node implements DAV\ICollection, DAV\IQuota, DAV\IMo
 	 * @return array Directory[]
  	 */
 	function ChannelList(&$auth) {
-		$ret = array();
+		$ret = [];
+
+		if (intval(get_config('system','cloud_disable_siteroot'))) {
+			return $ret;
+		}
 
 		$r = q("SELECT channel_id, channel_address, profile.publish FROM channel left join profile on profile.uid = channel.channel_id WHERE channel_removed = 0 AND channel_system = 0 AND (channel_pageflags & %d) = 0",
 			intval(PAGE_HIDDEN)
@@ -730,8 +734,7 @@ class Directory extends DAV\Node implements DAV\ICollection, DAV\IQuota, DAV\IMo
 			foreach ($r as $rr) {
 				if (perm_is_allowed($rr['channel_id'], $auth->observer, 'view_storage') && $rr['publish']) {
 					logger('found channel: /cloud/' . $rr['channel_address'], LOGGER_DATA);
-					// @todo can't we drop '/cloud'? It gets stripped off anyway in RedDirectory
+					$ret[] = new Directory($rr['channel_address'], $auth);
-					$ret[] = new Directory('/cloud/' . $rr['channel_address'], $auth);
 				}
 			}
 		}

util/zotsh/README.txt

@@ -16,6 +16,13 @@ Extract somewere and launch zotsh.py
 Description
 -----------
 
+Update: 2019-08-14
+
+Have just looked at this after several years of bitrot and made some updates.
+it functions for cli DAV access on your assigned hub, but magic-auth to dav repos on other hubs
+(e.g. the host command) needs to be updated to work with openwebauth.
+
+----
 ZotSH is a command line WebDAV client for Hubzilla.
 It knows how to magic-auth to remote hubs using Zot.
 

util/zotsh/easywebdav/client.py

@@ -31,7 +31,7 @@ File = namedtuple('File', ['name', 'size', 'mtime', 'ctime', 'contenttype'])
 
 def prop(elem, name, default=None):
     child = elem.find('.//{DAV:}' + name)
-    return default if child is None else child.text
+    return default if child is None or child.text is None else child.text
 
 
 def elem2file(elem):

util/zotsh/zotsh.py

@@ -1,10 +1,12 @@
-#!/usr/bin/env python2
+#!/usr/bin/env python
+
 import sys, os
 import ConfigParser
 import requests
 from requests.auth import HTTPBasicAuth
 import  easywebdav
 import easywebdav.__version__ as easywebdavversion
+import base64
 
 __version__= "0.0.2"
 
@@ -55,7 +57,7 @@ class ZotSH(object):
     @session.setter
     def session(self, session):
         self._session = session
-        self.davclient = easywebdav.connect( self.hostname, protocol='https', session=session, path="cloud", verify_ssl=VERIFY_SSL)
+        self.davclient = easywebdav.connect( self.hostname, protocol='https', session=session, path="dav", verify_ssl=VERIFY_SSL)
         
     @property
     def PS1(self):
@@ -82,12 +84,12 @@ class ZotSH(object):
             #session.params.update({'davguest':1})
         else:
             session = self.session
-        session.params.update({'davguest': (not  host == SERVER) })
+        #session.params.update({'davguest': (not  host == SERVER) })
         return session
     
     def do(self, command, *args):
         if not command in self.commands:
-            raise CommandNotFound("Unknow command '%s'" % command)
+            raise CommandNotFound("Unknown command '%s'" % command)
         
         cmd = getattr(self, "cmd_%s"%command, None)
         if cmd is None:
@@ -152,30 +154,17 @@ class ZotSH(object):
         session_remote = self.get_host_session(newhost)
         session_home = self.get_host_session(SERVER)
 
-        # call /magic on SERVER
+        bnewhost = newhost + 'dav'
+        bnewhost = bnewhost.encode('hex')
+        
         r = session_home.get( 
             SERVER + "magic",  
-            params={'dest': newhost},
+            params={'bdest': bnewhost, 'owa': 1},
-            allow_redirects=False,
+            allow_redirects=True,
             verify=VERIFY_SSL )
         
-        if not 'location' in r.headers:
-            raise Exception("Cannot start magic auth to '%s'" % newhostname)
-        auth_url = r.headers['location']
-
-
-        # call auth_url with "test" param
-    
-        r = session_remote.get( 
-            auth_url,
-            params={'test': 1 },
-            verify=VERIFY_SSL )
-
-        if r.json()['success']:
         self.hostname = newhostname
         self.session = session_remote
-        else:
-            raise Exception("Cannot magic auth to '%s'" % newhostname)
         
 
     def cmd_pwd(self, *args):
@@ -205,7 +194,7 @@ class ZotSH(object):
                 print _fmt('d', 0, "../")
                 
         for f in r:
-            name = f.name.replace("/cloud"+self.davclient.cwd,"")
+            name = f.name.replace("/dav"+self.davclient.cwd,"")
             type = "-"
             if name.endswith("/"):
                 type = "d"