harukin/core
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix a bug that made it possible for everyone to access any message from other

Browse Source 
channels using channel/<channel>/?mid=...
This commit is contained in:
zottel 2014-01-09 16:06:33 +01:00
parent 5d83855afd
commit a517a27d53
1 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
mod/channel.php
View File

@ -138,6 +138,17 @@ function channel_content(&$a, $update = 0, $load = false) {
$r = q("SELECT parent AS item_id from item where mid = '%s' limit 1", $r = q("SELECT parent AS item_id from item where mid = '%s' limit 1",
dbesc($mid) dbesc($mid)
); );
logger("update ");
if ($r) {
// make sure we don't show other people's posts from our matrix
$parent = q("SELECT owner_xchan from item where id = %d",
dbesc($r[0]['item_id'])
);
logger("update ");
logger($parent);
if ($parent['owner_xchan'] != $a->profile['channel_hash'])
$r = array();
}
} else { } else {
$r = q("SELECT distinct parent AS `item_id` from item $r = q("SELECT distinct parent AS `item_id` from item
left join abook on item.author_xchan = abook.abook_xchan left join abook on item.author_xchan = abook.abook_xchan
@ -177,6 +188,7 @@ function channel_content(&$a, $update = 0, $load = false) {
$r = q("SELECT parent AS item_id from item where mid = '%s' limit 1", $r = q("SELECT parent AS item_id from item where mid = '%s' limit 1",
dbesc($mid) dbesc($mid)
); );
logger("load ");
} else { } else {
$r = q("SELECT distinct id AS item_id FROM item $r = q("SELECT distinct id AS item_id FROM item
left join abook on item.author_xchan = abook.abook_xchan left join abook on item.author_xchan = abook.abook_xchan
@ -197,6 +209,20 @@ function channel_content(&$a, $update = 0, $load = false) {
} }
} }
if ($mid && $r) {
// make sure we don't show other people's posts from our matrix
// as $a->profile['channel_hash'] isn't set when a JS query comes in
// we have to do that with a join
$ismine = q("SELECT * from item
join channel on item.owner_xchan = channel.channel_hash
where item.id = %d and channel.channel_id = %d",
dbesc($r[0]['item_id']),
intval($a->profile['profile_uid'])
);
if (!$ismine)
$r = array();
}
if($r) { if($r) {
$parents_str = ids_to_querystr($r,'item_id'); $parents_str = ids_to_querystr($r,'item_id');