From 30e4a360847762bfc8afce6704261ea5cc38650c Mon Sep 17 00:00:00 2001 From: Thomas Willingham Date: Wed, 16 Oct 2013 17:08:19 +0100 Subject: [PATCH 1/3] Don't break themes by using functions we don't need. If you've got a theme that started off copying Redbasic (ie, all of you) need to do this too. --- view/theme/redbasic/php/config.php | 2 +- view/theme/redbasic/php/style.php | 11 ++++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/view/theme/redbasic/php/config.php b/view/theme/redbasic/php/config.php index faf6c6f35..44ddb78b9 100644 --- a/view/theme/redbasic/php/config.php +++ b/view/theme/redbasic/php/config.php @@ -39,7 +39,7 @@ function redbasic_form(&$a, $schema, $nav_colour, $bgcolour, $background_image, $scheme_choices = array(); $scheme_choices["---"] = t("Default"); - $files = glob('view/theme/' . current_theme() . '/schema/*'); + $files = glob('view/theme/redbasic/schema/*'); if($files) { foreach($files as $file) { $f = basename($file, ".php"); diff --git a/view/theme/redbasic/php/style.php b/view/theme/redbasic/php/style.php index b5d020937..1f3e46d9d 100644 --- a/view/theme/redbasic/php/style.php +++ b/view/theme/redbasic/php/style.php @@ -1,4 +1,5 @@ $nav_bg_1, From b860a21fdce3c4b99b7cecc8ac8d1f776e788197 Mon Sep 17 00:00:00 2001 From: Thomas Willingham Date: Wed, 16 Oct 2013 19:05:40 +0100 Subject: [PATCH 2/3] Check only for php in schema globs. --- view/theme/redbasic/php/config.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/view/theme/redbasic/php/config.php b/view/theme/redbasic/php/config.php index 44ddb78b9..90bd109ad 100644 --- a/view/theme/redbasic/php/config.php +++ b/view/theme/redbasic/php/config.php @@ -39,7 +39,7 @@ function redbasic_form(&$a, $schema, $nav_colour, $bgcolour, $background_image, $scheme_choices = array(); $scheme_choices["---"] = t("Default"); - $files = glob('view/theme/redbasic/schema/*'); + $files = glob('view/theme/redbasic/schema/*.php'); if($files) { foreach($files as $file) { $f = basename($file, ".php"); From 90fc3c1caf647214a079bfa12f92373e514276cd Mon Sep 17 00:00:00 2001 From: Thomas Willingham Date: Thu, 17 Oct 2013 02:16:47 +0100 Subject: [PATCH 3/3] Errant logging. --- view/theme/redbasic/php/style.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/view/theme/redbasic/php/style.php b/view/theme/redbasic/php/style.php index 1f3e46d9d..3344fcb3a 100644 --- a/view/theme/redbasic/php/style.php +++ b/view/theme/redbasic/php/style.php @@ -1,6 +1,4 @@