harukin/core
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a PHP7.2 warning when a channel has no cards.

Browse Source
This commit is contained in:
Klaus Weidenbach 2018-01-28 21:38:25 +01:00
parent edf6ad9eda
commit 82f19e6278
1 changed files with 41 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
Zotlabs/Module/Cards.php
View File

@ -19,6 +19,10 @@ class Cards extends \Zotlabs\Web\Controller {
} }
/**
* {@inheritDoc}
* @see \Zotlabs\Web\Controller::get()
*/
function get($update = 0, $load = false) { function get($update = 0, $load = false) {
if(observer_prohibited(true)) { if(observer_prohibited(true)) {
@ -74,12 +78,12 @@ class Cards extends \Zotlabs\Web\Controller {
$channel = channelx_by_n($owner); $channel = channelx_by_n($owner);
if($channel) { if($channel) {
$channel_acl = array( $channel_acl = [
'allow_cid' => $channel['channel_allow_cid'], 'allow_cid' => $channel['channel_allow_cid'],
'allow_gid' => $channel['channel_allow_gid'], 'allow_gid' => $channel['channel_allow_gid'],
'deny_cid' => $channel['channel_deny_cid'], 'deny_cid' => $channel['channel_deny_cid'],
'deny_gid' => $channel['channel_deny_gid'] 'deny_gid' => $channel['channel_deny_gid']
); ];
} }
else { else {
$channel_acl = [ 'allow_cid' => '', 'allow_gid' => '', 'deny_cid' => '', 'deny_gid' => '' ]; $channel_acl = [ 'allow_cid' => '', 'allow_gid' => '', 'deny_cid' => '', 'deny_gid' => '' ];
@ -119,8 +123,8 @@ class Cards extends \Zotlabs\Web\Controller {
$x['title'] = $_REQUEST['title']; $x['title'] = $_REQUEST['title'];
if($_REQUEST['body']) if($_REQUEST['body'])
$x['body'] = $_REQUEST['body']; $x['body'] = $_REQUEST['body'];
$editor = status_editor($a,$x);
$editor = status_editor($a, $x);
} }
else { else {
$editor = ''; $editor = '';
@ -149,6 +153,7 @@ class Cards extends \Zotlabs\Web\Controller {
and item.item_unpublished = 0 and item.item_delayed = 0 and item.item_pending_remove = 0 and item.item_unpublished = 0 and item.item_delayed = 0 and item.item_pending_remove = 0
and item.item_blocked = 0 "; and item.item_blocked = 0 ";
$items_result = [];
if($r) { if($r) {
$parents_str = ids_to_querystr($r, 'id'); $parents_str = ids_to_querystr($r, 'id');
@ -164,21 +169,19 @@ class Cards extends \Zotlabs\Web\Controller {
if($items) { if($items) {
xchan_query($items); xchan_query($items);
$items = fetch_post_tags($items, true); $items = fetch_post_tags($items, true);
$items = conv_sort($items,'updated'); $items_result = conv_sort($items, 'updated');
} }
else
$items = [];
} }
$mode = 'cards'; $mode = 'cards';
$content = conversation($items,$mode,false,'traditional'); $content = conversation($items_result, $mode, false, 'traditional');
$o = replace_macros(get_markup_template('cards.tpl'), [ $o = replace_macros(get_markup_template('cards.tpl'), [
'$title' => t('Cards'), '$title' => t('Cards'),
'$editor' => $editor, '$editor' => $editor,
'$content' => $content, '$content' => $content,
'$pager' => alt_pager($a,count($items)) '$pager' => alt_pager($a, count($items_result))
]); ]);
return $o; return $o;