From 6f8d29ad8076fc53019739cdc9afa3d15d250d8e Mon Sep 17 00:00:00 2001 From: Mario Vavti Date: Thu, 22 Oct 2015 10:52:10 +0200 Subject: [PATCH 1/6] move photo object stuff from itemObject to prepare_body() so we can do more stuff with it --- include/ItemObject.php | 14 +----------- include/text.php | 37 ++++++++++++++++++++++--------- view/css/conversation.css | 5 ----- view/theme/redbasic/css/style.css | 5 ++++- view/tpl/conv_item.tpl | 4 ++-- 5 files changed, 34 insertions(+), 31 deletions(-) diff --git a/include/ItemObject.php b/include/ItemObject.php index 9fe86118c..c5c2cb2e6 100644 --- a/include/ItemObject.php +++ b/include/ItemObject.php @@ -278,17 +278,6 @@ class Item extends BaseObject { $children = $this->get_children(); - $is_photo = (($item['obj_type'] == ACTIVITY_OBJ_PHOTO) ? true : false); - if($is_photo) { - $object = json_decode($item['object'],true); - $photo = array( - 'url' => rawurldecode($object['id']) . '?zid=' . $observer['xchan_addr'], - 'link' => rawurldecode(get_rel_link($object['link'],'alternate')) . '?zid=' . $observer['xchan_addr'], - 'width' => $object['width'], - 'height' => $object['height'] - ); - } - $has_tags = (($body['tags'] || $body['categories'] || $body['mentions'] || $body['attachments'] || $body['folders']) ? true : false); $tmp_item = array( @@ -342,8 +331,7 @@ class Item extends BaseObject { 'owner_url' => $this->get_owner_url(), 'owner_photo' => $this->get_owner_photo(), 'owner_name' => $this->get_owner_name(), - 'is_photo' => $is_photo, - 'photo' => (($is_photo) ? $photo : ''), + 'photo' => $body['photo'], 'has_tags' => $has_tags, // Item toolbar buttons diff --git a/include/text.php b/include/text.php index d395a2523..d918a865a 100644 --- a/include/text.php +++ b/include/text.php @@ -1363,6 +1363,7 @@ function generate_named_map($location) { function prepare_body(&$item,$attach = false) { + require_once('include/identity.php'); // if($item['html']) { // $s = bb_observer($item['html']); @@ -1373,9 +1374,22 @@ function prepare_body(&$item,$attach = false) { $s = prepare_text($item['body'],$item['mimetype'], false); // } - $prep_arr = array('item' => $item, 'html' => $s); + $is_photo = (($item['obj_type'] === ACTIVITY_OBJ_PHOTO) ? true : false); + if($is_photo) { + $object = json_decode($item['object'],true); + $photo = ''; + } + + $prep_arr = array( + 'item' => $item, + 'html' => $s, + 'photo' => $photo + ); + call_hooks('prepare_body', $prep_arr); + $s = $prep_arr['html']; + $photo = $prep_arr['photo']; // q("update item set html = '%s' where id = %d", // dbesc($s), @@ -1391,7 +1405,7 @@ function prepare_body(&$item,$attach = false) { if($x) { $s = preg_replace('/\
/','$0' . $x,$s); } - } + } $attachments = theme_attachments($item); @@ -1439,17 +1453,20 @@ function prepare_body(&$item,$attach = false) { } $prep_arr = array( - //'item' => $item, - 'html' => $s, - 'categories' => $categories, - 'folders' => $filer, - 'tags' => $tags, - 'mentions' => $mentions, - 'attachments' => $attachments - ); + 'item' => $item, + 'photo' => $photo, + 'html' => $s, + 'categories' => $categories, + 'folders' => $filer, + 'tags' => $tags, + 'mentions' => $mentions, + 'attachments' => $attachments + ); call_hooks('prepare_body_final', $prep_arr); + unset($prep_arr['item']); + return $prep_arr; } diff --git a/view/css/conversation.css b/view/css/conversation.css index ecdf9dc2f..6f1d4b899 100644 --- a/view/css/conversation.css +++ b/view/css/conversation.css @@ -77,11 +77,6 @@ code { /* conv_item */ -.wall-photo-item { - display: table; - margin: 0px auto; -} - .wall-item-info { display: block; float: left; diff --git a/view/theme/redbasic/css/style.css b/view/theme/redbasic/css/style.css index e079af4da..d90e9e7c8 100644 --- a/view/theme/redbasic/css/style.css +++ b/view/theme/redbasic/css/style.css @@ -1621,6 +1621,10 @@ img.mail-conv-sender-photo { } /* conversation */ +.nsfw-wrap { + text-align: center; + font-size: $body_font_size; +} .wall-item-head { padding: 10px 10px 0.5em 10px; @@ -1762,7 +1766,6 @@ img.mail-conv-sender-photo { .divgrow-showmore:hover { border-top: 1px dashed #adadad; - text-decoration: underline; } diff --git a/view/tpl/conv_item.tpl b/view/tpl/conv_item.tpl index 0a6622fa4..e6e9d880e 100755 --- a/view/tpl/conv_item.tpl +++ b/view/tpl/conv_item.tpl @@ -33,9 +33,9 @@
- {{if $item.is_photo}} + {{if $item.photo}}
- + {{$item.photo}}
{{/if}} {{if $item.body}} From 735f9c7a45fc1f5b149bb1798a2d438516655a5c Mon Sep 17 00:00:00 2001 From: Mario Vavti Date: Thu, 22 Oct 2015 11:37:34 +0200 Subject: [PATCH 2/6] define $photo --- include/text.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/text.php b/include/text.php index d918a865a..544e7aa68 100644 --- a/include/text.php +++ b/include/text.php @@ -1375,6 +1375,8 @@ function prepare_body(&$item,$attach = false) { // } $is_photo = (($item['obj_type'] === ACTIVITY_OBJ_PHOTO) ? true : false); + $photo = ''; + if($is_photo) { $object = json_decode($item['object'],true); $photo = ''; From 5395b173aa514b5dc99768c259f7b04c97ff9743 Mon Sep 17 00:00:00 2001 From: Mario Vavti Date: Thu, 22 Oct 2015 12:09:19 +0200 Subject: [PATCH 3/6] implement the new anchor target behaviour --- include/text.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/text.php b/include/text.php index 544e7aa68..11062a1b2 100644 --- a/include/text.php +++ b/include/text.php @@ -1379,7 +1379,7 @@ function prepare_body(&$item,$attach = false) { if($is_photo) { $object = json_decode($item['object'],true); - $photo = ''; + $photo = ''; } $prep_arr = array( From bcb4ac7aaeedbd776b3eb1cb66f85eb48a14040c Mon Sep 17 00:00:00 2001 From: Mario Vavti Date: Thu, 22 Oct 2015 12:58:11 +0200 Subject: [PATCH 4/6] experiment: put the photo-item photo on top of the post --- view/theme/redbasic/css/style.css | 8 +++++++- view/tpl/conv_item.tpl | 11 ++++++----- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/view/theme/redbasic/css/style.css b/view/theme/redbasic/css/style.css index d90e9e7c8..d01abff8e 100644 --- a/view/theme/redbasic/css/style.css +++ b/view/theme/redbasic/css/style.css @@ -1635,7 +1635,13 @@ img.mail-conv-sender-photo { } .wall-photo-item { - padding: 0.5em 0px; + /*padding: 0.5em 10px;*/ +} + +.wall-photo-item img { + max-width: 100% !important; + border-top-right-radius: $radiuspx; + border-top-left-radius: $radiuspx; } .wall-item-tools { diff --git a/view/tpl/conv_item.tpl b/view/tpl/conv_item.tpl index e6e9d880e..760d64db0 100755 --- a/view/tpl/conv_item.tpl +++ b/view/tpl/conv_item.tpl @@ -8,6 +8,11 @@
+ {{if $item.photo}} +
+ {{$item.photo}} +
+ {{/if}}
@@ -33,11 +38,7 @@
- {{if $item.photo}} -
- {{$item.photo}} -
- {{/if}} + {{if $item.body}}
From ed6629002f25464ce03ab3daa0676dc34561d082 Mon Sep 17 00:00:00 2001 From: Mario Vavti Date: Thu, 22 Oct 2015 13:01:33 +0200 Subject: [PATCH 5/6] photo object fixes --- view/tpl/conv_list.tpl | 5 +++++ view/tpl/search_item.tpl | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/view/tpl/conv_list.tpl b/view/tpl/conv_list.tpl index 65b695a70..a3fb642ce 100755 --- a/view/tpl/conv_list.tpl +++ b/view/tpl/conv_list.tpl @@ -8,6 +8,11 @@
+ {{if $item.photo}} +
+ {{$item.photo}} +
+ {{/if}}
diff --git a/view/tpl/search_item.tpl b/view/tpl/search_item.tpl index 003dae993..b44e1c39e 100755 --- a/view/tpl/search_item.tpl +++ b/view/tpl/search_item.tpl @@ -2,6 +2,11 @@
+ {{if $item.photo}} +
+ {{$item.photo}} +
+ {{/if}}
From 379fd33484f765a5d85f88e5e418dea05d669168 Mon Sep 17 00:00:00 2001 From: mcnesium Date: Thu, 22 Oct 2015 13:44:33 +0200 Subject: [PATCH 6/6] fix placeholder font-family [Imgur](http://i.imgur.com/Cegabd5.png) --- view/theme/redbasic/css/style.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/view/theme/redbasic/css/style.css b/view/theme/redbasic/css/style.css index d01abff8e..e6ca7cbc3 100644 --- a/view/theme/redbasic/css/style.css +++ b/view/theme/redbasic/css/style.css @@ -794,11 +794,11 @@ a.rateme, div.rateme { } #nav-search-text::-webkit-input-placeholder { - font-family: FontAwesome; + font-family: FontAwesome, sans-serif; } #nav-search-text::-moz-placeholder { - font-family: FontAwesome; + font-family: FontAwesome, sans-serif; } nav .acpopup {