harukin/core
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

✅ Add tests for non existent tables.

Browse Source 
Prevent PHP warnings "Undefined variable" in dba_pdo::q();
This commit is contained in:
Klaus Weidenbach 2018-01-22 22:59:13 +01:00
parent 509844fd7e
commit 4bf0c9e36a
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/dba/dba_pdo.php
View File

@ -66,8 +66,9 @@ class dba_pdo extends dba_driver {
}
}
$result = null;
$this->error = '';
$select = ((stripos($sql,'select') === 0) ? true : false);
$select = ((stripos($sql, 'select') === 0) ? true : false);
try {
$result = $this->db->query($sql, PDO::FETCH_ASSOC);

22
tests/unit/includes/dba/dba_pdoTest.php
View File

@ -164,4 +164,26 @@ class dba_pdoTest extends DatabaseTestCase {
$this->assertFalse($nodba->q('SELECT * FROM account'));
}
/**
* @depends testConnectToSqlServer
*/
public function testSelectQueryToNonExistentTableShouldReturnFalse() {
$ret = $this->dba->q('SELECT * FROM non_existent_table');
$this->assertFalse($ret);
}
/**
* @depends testConnectToSqlServer
*/
public function testInsertQueryToNonExistentTableShouldReturnEmptyArray() {
$ret = $this->dba->q('INSERT INTO non_existent_table
(account_email, account_language)
VALUES (\'email@example.com\', \'en\')
');
$this->assertNotInstanceOf('PDOStatement', $ret);
$this->isEmpty($ret);
}
}