disable repeat unless mid is a resolvable uri since this will do radically different things on different network stacks (e.g. Diaspora) and it turns out there is no possible way to make Diaspora reshares compatible with ActivityPub or Zot6 repeat/announce/boost/whatever.

This commit is contained in:
zotlabs 2019-02-07 14:38:05 -08:00
parent f02af5fe6e
commit 317c53acf6
2 changed files with 5 additions and 6 deletions

View File

@ -294,7 +294,11 @@ class ThreadItem {
}
if ($shareable) {
$share = array( t('Repeat This'), t('repeat'));
// This actually turns out not to be possible in some protocol stacks without opening up hundreds of new issues.
// Will allow it only for uri resolvable sources.
if(strpos($item['mid'],'http') === 0) {
$share = array( t('Repeat This'), t('repeat'));
}
$embed = array( t('Share This'), t('share'));
}

View File

@ -51,11 +51,6 @@ class Share extends \Zotlabs\Web\Controller {
if($r[0]['mimetype'] !== 'text/bbcode')
killme();
if(strpos($r[0]['mid'],'http') === false) {
notice( t('Source message cannot be repeated. Sharing instead.') . EOL);
goaway(z_root() . '/embed/' . argv(1));
}
xchan_query($r);