harukin/core
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mod hq: do not 404 if we have no item

Browse Source
This commit is contained in:
Mario Vavti 2017-12-04 08:54:56 +01:00
parent dae0107dd0
commit 11b03ca4d2
1 changed files with 59 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

108
Zotlabs/Module/Hq.php
View File

@ -53,29 +53,53 @@ class Hq extends \Zotlabs\Web\Controller {
$r = q("SELECT mid FROM item $r = q("SELECT mid FROM item
WHERE uid = %d WHERE uid = %d
AND mid = parent_mid AND mid = parent_mid
ORDER BY created DESC ORDER BY created DESC LIMIT 1",
limit 1",
intval(local_channel()) intval(local_channel())
); );
if(!$r[0]['mid']) { if($r[0]['mid']) {
\App::$error = 404; $item_hash = 'b64.' . base64url_encode($r[0]['mid']);
notice( t('Item not found.') . EOL);
return;
} }
$item_hash = 'b64.' . base64url_encode($r[0]['mid']);
} }
if($item_hash) {
if(strpos($item_hash,'b64.') === 0) if(strpos($item_hash,'b64.') === 0)
$decoded = @base64url_decode(substr($item_hash,4)); $decoded = @base64url_decode(substr($item_hash,4));
if($decoded) if($decoded)
$item_hash = $decoded; $item_hash = $decoded;
$target_item = null;
$r = q("select id, uid, mid, parent_mid, thr_parent, verb, item_type, item_deleted, item_blocked from item where mid like '%s' limit 1",
dbesc($item_hash . '%')
);
if($r) {
$target_item = $r[0];
}
//if the item is to be moderated redirect to /moderate
if($target_item['item_blocked'] == ITEM_MODERATED) {
goaway(z_root() . '/moderate/' . $target_item['id']);
}
$static = ((array_key_exists('static',$_REQUEST)) ? intval($_REQUEST['static']) : 0);
$simple_update = (($update) ? " AND item_unseen = 1 " : '');
if($update && $_SESSION['loadtime'])
$simple_update = " AND (( item_unseen = 1 AND item.changed > '" . datetime_convert('UTC','UTC',$_SESSION['loadtime']) . "' ) OR item.changed > '" . datetime_convert('UTC','UTC',$_SESSION['loadtime']) . "' ) ";
if($static && $simple_update)
$simple_update .= " and item_thread_top = 0 and author_xchan = '" . protect_sprintf(get_observer_hash()) . "' ";
$sys = get_sys_channel();
$sql_extra = item_permissions_sql($sys['channel_id']);
}
$updateable = false;
if(! $update) { if(! $update) {
$channel = \App::get_channel(); $channel = \App::get_channel();
@ -105,52 +129,36 @@ class Hq extends \Zotlabs\Web\Controller {
'bbcode' => true, 'bbcode' => true,
'jotnets' => true 'jotnets' => true
]; ];
$o = replace_macros(get_markup_template("hq.tpl"),
[
'$no_messages' => (($target_item) ? false : true),
'$no_messages_label' => t('Welcome to hubzilla!')
]
);
$o = '<div id="jot-popup">'; $o = '<div id="jot-popup">';
$o .= status_editor($a,$x); $o .= status_editor($a,$x);
$o .= '</div>'; $o .= '</div>';
} }
$target_item = null;
$r = q("select id, uid, mid, parent_mid, thr_parent, verb, item_type, item_deleted, item_blocked from item where mid like '%s' limit 1",
dbesc($item_hash . '%')
);
if($r) {
$target_item = $r[0];
}
//if the item is to be moderated redirect to /moderate
if($target_item['item_blocked'] == ITEM_MODERATED) {
goaway(z_root() . '/moderate/' . $target_item['id']);
}
$static = ((array_key_exists('static',$_REQUEST)) ? intval($_REQUEST['static']) : 0);
$simple_update = (($update) ? " AND item_unseen = 1 " : '');
if($update && $_SESSION['loadtime'])
$simple_update = " AND (( item_unseen = 1 AND item.changed > '" . datetime_convert('UTC','UTC',$_SESSION['loadtime']) . "' ) OR item.changed > '" . datetime_convert('UTC','UTC',$_SESSION['loadtime']) . "' ) ";
if($static && $simple_update)
$simple_update .= " and item_thread_top = 0 and author_xchan = '" . protect_sprintf(get_observer_hash()) . "' ";
$sys = get_sys_channel();
$sql_extra = item_permissions_sql($sys['channel_id']);
if(! $update && ! $load) { if(! $update && ! $load) {
nav_set_selected('HQ'); nav_set_selected('HQ');
$static = ((local_channel()) ? channel_manual_conv_update(local_channel()) : 1); $static = ((local_channel()) ? channel_manual_conv_update(local_channel()) : 1);
// if the target item is not a post (eg a like) we want to address its thread parent if($target_item) {
$mid = ((($target_item['verb'] == ACTIVITY_LIKE) || ($target_item['verb'] == ACTIVITY_DISLIKE)) ? $target_item['thr_parent'] : $target_item['mid']); // if the target item is not a post (eg a like) we want to address its thread parent
$mid = ((($target_item['verb'] == ACTIVITY_LIKE) || ($target_item['verb'] == ACTIVITY_DISLIKE)) ? $target_item['thr_parent'] : $target_item['mid']);
// if we got a decoded hash we must encode it again before handing to javascript // if we got a decoded hash we must encode it again before handing to javascript
if($decoded) if($decoded)
$mid = 'b64.' . base64url_encode($mid); $mid = 'b64.' . base64url_encode($mid);
}
else {
$mid = '';
}
$o .= '<div id="live-hq"></div>' . "\r\n"; $o .= '<div id="live-hq"></div>' . "\r\n";
$o .= "<script> var profile_uid = " . local_channel() $o .= "<script> var profile_uid = " . local_channel()
@ -188,7 +196,9 @@ class Hq extends \Zotlabs\Web\Controller {
]); ]);
} }
if($load) { $updateable = false;
if($load && $target_item) {
$r = null; $r = null;
$r = q("SELECT item.id AS item_id FROM item $r = q("SELECT item.id AS item_id FROM item
@ -215,7 +225,7 @@ class Hq extends \Zotlabs\Web\Controller {
); );
} }
} }
elseif($update) { elseif($update && $target_item) {
$r = null; $r = null;
$r = q("SELECT item.parent AS item_id FROM item $r = q("SELECT item.parent AS item_id FROM item